[build] internal/relui: leave out GOROOT_FINAL when building distpacks

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

internal/relui: leave out GOROOT_FINAL when building distpacks

As of Go 1.23, the GOROOT_FINAL environment variable is no more¹,
and so it's no longer necessary to set it here. Start gradually
removing it.

Also, delete some code that became dead as of Go 1.24.0 release,
and unnest a leftover code block.

¹ https://go.dev/doc/go1.23#go-command

For golang/go#62047.

Change-Id: I788fd9a2dc2b60ee071aca8a231fc538fdc776cf

Reviewed-on: https://go-review.googlesource.com/c/build/+/743341

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>

Files:

• M internal/relui/workflows.go
• M internal/task/tweet.go
• M internal/task/tweet_test.go

Change size: M

Delta: 3 files changed, 18 insertions(+), 63 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Dmitri Shuralyov, +2 by Michael Pratt
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: build

Gerrit-Branch: master

Gerrit-Change-Id: I788fd9a2dc2b60ee071aca8a231fc538fdc776cf

Gerrit-Change-Number: 743341

Gerrit-PatchSet: 2

Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>