[benchmarks] sweet/benchmarks/internal/driver: don't swallow perf stderr

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
9:48 AM (9 hours ago) 9:48 AM
to Austin Clements, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Michael Pratt, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
sweet/benchmarks/internal/driver: don't swallow perf stderr

It took me way too long to figure out why I wasn't getting perf data
when I had forgotten to enable the magic sysctls and wasn't getting
the usual hint from perf.
Change-Id: I5e518b024dccff45ff06daa84ac866708c1d4ddc
Reviewed-by: Michael Knyszek <mkny...@google.com>
Auto-Submit: Austin Clements <aus...@google.com>
Files:
  • M sweet/benchmarks/internal/driver/driver.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: benchmarks
Gerrit-Branch: master
Gerrit-Change-Id: I5e518b024dccff45ff06daa84ac866708c1d4ddc
Gerrit-Change-Number: 600061
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages