[sync] errgroup: use consistent read for SetLimit panic
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Dec 3, 2025, 7:24:43 PM (7 hours ago) Dec 3
to Justin Mayhew, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Alan Donovan, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
errgroup: use consistent read for SetLimit panic
This could produce a confusing panic message if the second len(g.sem)
call returns 0. Avoid that by reading it once.
Change-Id: Ibdb4963f90921bc20427b3f1e2de410638f6cb6b
Reviewed-on: https://go-review.googlesource.com/c/sync/+/726280
Reviewed-by: Alan Donovan <adon...@google.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Sean Liao <se...@liao.dev>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M errgroup/errgroup.go
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Sean Liao, +1 by Dmitri Shuralyov, +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages