[pkgsite] internal/source: clean up redundancies and typos after CL 708175

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

May 11, 2026, 4:59:34 PM (7 hours ago) May 11

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: internal/source/meta-tags.go
Insertions: 2, Deletions: 2.

@@ -102,9 +102,9 @@
 				repoSubdir := ""
 				switch len(fields) {
 				case 3:
-					// go-import meta tag support minimum 3 fields (root-path vcs repo-url).
+					// go-import meta tag supports a minimum of 3 fields (root-path vcs repo-url).
 				case 4:
-					// go-import meta tag support minimum 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
+					// go-import meta tag supports a minimum of 3 fields (root-path vcs repo-url), and additionally "subdirectory" field since Go 1.25.
 					repoSubdir = fields[3]
 				default:
 					errorMessage = "go-import meta tag content attribute does not have three or four fields"
```

Change information

Commit message:

internal/source: clean up redundancies and typos after CL 708175

Remove redundant assignment of repoSubdir and redundant break in
switch statement in internal/source/meta-tags.go.
Fix typos in comments ("minium" -> "minimum").

Change-Id: I24e413c3942f5af50dfeec594b96b680b04ff7e2

Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/776840

Auto-Submit: Hyang-Ah Hana Kim <hya...@gmail.com>

kokoro-CI: kokoro <noreply...@google.com>

Reviewed-by: Nicholas Husin <n...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Nicholas Husin <hu...@google.com>

Files:

M internal/source/meta-tags.go

Change size: XS

Delta: 1 file changed, 2 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Nicholas Husin, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages