[go] cmd/compile: refactor preserveStmt

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

10:30 AM (3 hours ago) 10:30 AM

to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Junyang Shao, Keith Randall, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/compile: refactor preserveStmt

By breaking it into smaller functions with duplicated logic removed.

Change-Id: I710414e8d13d91c19fb4bf4da1a31b00ee88ccee

Reviewed-on: https://go-review.googlesource.com/c/go/+/728961

Reviewed-by: Junyang Shao <shaoj...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Keith Randall <k...@google.com>

Reviewed-by: Keith Randall <k...@golang.org>

Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>

Files:

M src/cmd/compile/internal/bloop/bloop.go

Change size: M

Delta: 1 file changed, 99 insertions(+), 128 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Keith Randall, +2 by Junyang Shao, +2 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages