[tools] internal/analysisinternal: rationalize dependencies
0 views
Skip to first unread message
Alan Donovan (Gerrit)
Nov 10, 2025, 3:19:14 PM (2 days ago) Nov 10
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Robert Findley, golang-co...@googlegroups.com
Alan Donovan submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
internal/analysisinternal: rationalize dependencies
This change moves all declarations in the analysisinternal
package into one of two subpackages:
- driverutil, for implementation helper functions for drivers
such as unitchecker, {single,multi}checker, and analysistest; and
- analyzerutil, for helper functions for Analyzers.
A number of declarations from go/analysis/internal/analysisflags
also moved into driverlib. analysisflags is now concerned only
with command-line flag parsing.
No behavior changes.
A followup CL will rename analysisinternal to just analysis
since it is now just a path segment, not a package to be imported.
Change-Id: Ibdd36aa80f6d8faf17938e715c05a8efb36f2195
Reviewed-on: https://go-review.googlesource.com/c/tools/+/718081
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Robert Findley <rfin...@google.com>
Files:
- M go/analysis/analysistest/analysistest.go
- M go/analysis/checker/checker.go
- M go/analysis/checker/print.go
- M go/analysis/internal/analysisflags/flags.go
- M go/analysis/internal/checker/checker.go
- M go/analysis/passes/appends/appends.go
- M go/analysis/passes/asmdecl/asmdecl.go
- M go/analysis/passes/assign/assign.go
- M go/analysis/passes/atomic/atomic.go
- M go/analysis/passes/buildtag/buildtag.go
- M go/analysis/passes/defers/defers.go
- M go/analysis/passes/directive/directive.go
- M go/analysis/passes/framepointer/framepointer.go
- M go/analysis/passes/gofix/gofix.go
- M go/analysis/passes/ifaceassert/ifaceassert.go
- M go/analysis/passes/inline/inline.go
- M go/analysis/passes/loopclosure/loopclosure.go
- M go/analysis/passes/lostcancel/lostcancel.go
- M go/analysis/passes/modernize/any.go
- M go/analysis/passes/modernize/bloop.go
- M go/analysis/passes/modernize/errorsastype.go
- M go/analysis/passes/modernize/fmtappendf.go
- M go/analysis/passes/modernize/forvar.go
- M go/analysis/passes/modernize/maps.go
- M go/analysis/passes/modernize/minmax.go
- M go/analysis/passes/modernize/newexpr.go
- M go/analysis/passes/modernize/omitzero.go
- M go/analysis/passes/modernize/plusbuild.go
- M go/analysis/passes/modernize/rangeint.go
- M go/analysis/passes/modernize/reflect.go
- M go/analysis/passes/modernize/slices.go
- M go/analysis/passes/modernize/slicescontains.go
- M go/analysis/passes/modernize/slicesdelete.go
- M go/analysis/passes/modernize/sortslice.go
- M go/analysis/passes/modernize/stditerators.go
- M go/analysis/passes/modernize/stringsbuilder.go
- M go/analysis/passes/modernize/stringscut.go
- M go/analysis/passes/modernize/stringscutprefix.go
- M go/analysis/passes/modernize/stringsseq.go
- M go/analysis/passes/modernize/testingcontext.go
- M go/analysis/passes/modernize/waitgroup.go
- M go/analysis/passes/nilfunc/nilfunc.go
- M go/analysis/passes/nilness/nilness.go
- M go/analysis/passes/printf/printf.go
- M go/analysis/passes/reflectvaluecompare/reflectvaluecompare.go
- M go/analysis/passes/shadow/shadow.go
- M go/analysis/passes/sigchanyzer/sigchanyzer.go
- M go/analysis/passes/slog/slog.go
- M go/analysis/passes/stdmethods/stdmethods.go
- M go/analysis/passes/stringintconv/string.go
- M go/analysis/passes/testinggoroutine/testinggoroutine.go
- M go/analysis/passes/tests/tests.go
- M go/analysis/passes/timeformat/timeformat.go
- M go/analysis/passes/unmarshal/unmarshal.go
- M go/analysis/passes/unreachable/unreachable.go
- M go/analysis/passes/unsafeptr/unsafeptr.go
- M go/analysis/passes/unusedresult/unusedresult.go
- M go/analysis/passes/unusedwrite/unusedwrite.go
- M go/analysis/passes/usesgenerics/usesgenerics.go
- M go/analysis/passes/waitgroup/waitgroup.go
- M go/analysis/unitchecker/unitchecker.go
- M gopls/internal/analysis/deprecated/deprecated.go
- M gopls/internal/analysis/embeddirective/embeddirective.go
- M gopls/internal/analysis/fillreturns/fillreturns.go
- M gopls/internal/analysis/maprange/maprange.go
- M gopls/internal/analysis/nonewvars/nonewvars.go
- M gopls/internal/analysis/noresultvalues/noresultvalues.go
- M gopls/internal/analysis/recursiveiter/recursiveiter.go
- M gopls/internal/analysis/simplifycompositelit/simplifycompositelit.go
- M gopls/internal/analysis/simplifyrange/simplifyrange.go
- M gopls/internal/analysis/simplifyslice/simplifyslice.go
- M gopls/internal/analysis/unusedfunc/unusedfunc.go
- M gopls/internal/analysis/unusedparams/unusedparams.go
- M gopls/internal/analysis/yield/yield.go
- M gopls/internal/cache/analysis.go
- A internal/analysisinternal/analyzerutil/doc.go
- R internal/analysisinternal/analyzerutil/extractdoc.go
- R internal/analysisinternal/analyzerutil/extractdoc_test.go
- A internal/analysisinternal/analyzerutil/readfile.go
- R internal/analysisinternal/driverutil/fix.go
- A internal/analysisinternal/driverutil/print.go
- A internal/analysisinternal/driverutil/readfile.go
- R internal/analysisinternal/driverutil/url.go
- R internal/analysisinternal/driverutil/url_test.go
- R internal/analysisinternal/driverutil/validatefix.go
Change size: L
Delta: 85 files changed, 434 insertions(+), 397 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Robert Findley
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages