[go/release-branch.go1.25] [release-branch.go1.25] fix incorrect loop trip counts

0 views

Skip to first unread message

Carlos Amedee (Gerrit)

unread,

Apr 23, 2026, 4:17:54 PM (2 days ago) Apr 23

to Mark Freeman, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Keith Randall, Jorropo, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:

[release-branch.go1.25] fix incorrect loop trip counts

While CL 758801 addresses this fix on tip, it does not apply
cleanly on go1.25 or go1.26. In the interest of safety, this
disables loop inversion; it's the least invasive path.

Fixes #78374

Change-Id: Iaac5825c143669eb626352d3a965978f93f8f505

Reviewed-on: https://go-review.googlesource.com/c/go/+/766981

Reviewed-by: Keith Randall <k...@google.com>

TryBot-Bypass: Carlos Amedee <car...@golang.org>

Reviewed-by: Jorropo <jorro...@gmail.com>

Reviewed-by: Carlos Amedee <car...@golang.org>

Files:

M src/cmd/compile/internal/ssa/prove.go

Change size: M

Delta: 1 file changed, 0 insertions(+), 118 deletions(-)

Branch: refs/heads/release-branch.go1.25

Submit Requirements:

Code-Review: +1 by Carlos Amedee, +2 by Jorropo, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com, TryBot-Bypass+1 by Carlos Amedee

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Carlos Amedee (Gerrit)

unread,

Apr 23, 2026, 4:17:59 PM (2 days ago) Apr 23

to Mark Freeman, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Keith Randall, Jorropo, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:

[release-branch.go1.26] fix incorrect loop trip counts



While CL 758801 addresses this fix on tip, it does not apply
cleanly on go1.25 or go1.26. In the interest of safety, this
disables loop inversion; it's the least invasive path.

Fixes #78375

Change-Id: Iac399ca47b811042dc5f38272d201d3dc61390b8

Reviewed-on: https://go-review.googlesource.com/c/go/+/766982

Reviewed-by: Jorropo <jorro...@gmail.com>

TryBot-Bypass: Dmitri Shuralyov <dmit...@golang.org>

Reviewed-by: Keith Randall <k...@google.com>

Files:

M src/cmd/compile/internal/ssa/prove.go

Change size: M

Delta: 1 file changed, 0 insertions(+), 118 deletions(-)

Branch: refs/heads/release-branch.go1.26

Submit Requirements:

Code-Review: +1 by Keith Randall, +2 by Jorropo
TryBots-Pass: LUCI-TryBot-Result-1 by golang...@luci-project-accounts.iam.gserviceaccount.com, TryBot-Bypass+1 by Dmitri Shuralyov

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages