[mobile] cmd/gomobile: use slash-separated Android asset paths

0 views

Skip to first unread message

Hajime Hoshi (Gerrit)

unread,

12:55 PM (4 hours ago) 12:55 PM

to race quite, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, Gopher Robot, golang-co...@googlegroups.com

Hajime Hoshi submitted the change

Change information

Commit message:

cmd/gomobile: use slash-separated Android asset paths

Asset names added to AAR and APK archives are currently derived by
slicing paths returned by filepath.Walk. On Windows, nested asset names
therefore contain backslashes, which are not portable archive
separators.

Compute each name relative to the asset root and convert it with
filepath.ToSlash. Reuse the relative path already calculated for APK
icon detection.

Add a nested test asset and verify that Android can open it using a
slash-separated path.

Fixes golang/go#80659

Change-Id: Ie962bb27fa9de88231f59211a1c47d532f1eb15b

Reviewed-on: https://go-review.googlesource.com/c/mobile/+/808381

Reviewed-by: race quite <quit...@gmail.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Mark Freeman <ma...@golang.org>

Reviewed-by: Hajime Hoshi <hajim...@gmail.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M bind/java/SeqTest.java
A bind/testdata/testpkg/assets/nested/hello.txt
M cmd/gomobile/bind_androidapp.go
M cmd/gomobile/build_androidapp.go

Change size: S

Delta: 4 files changed, 24 insertions(+), 3 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Mark Freeman, +1 by race quite, +2 by Hajime Hoshi, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages