[tools] go/analysis/passes/modernize: stringscut: detect use in multi-assign
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Apr 29, 2026, 4:25:03 PM (20 hours ago) Apr 29
to Madeline Kalil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
go/analysis/passes/modernize: stringscut: detect modifying use in all assignments
In the stringscut modernizer, we skip suggesting a fix if any of the uses of the input variable "s" (after the call to Index) are modifying uses, as a fix would not preserve the existing semantics.
When looking at a use of "s" in an assignment, we previously only check Lhs[0]. If the "s" is modified in a multi-assignment but is not the first variable in the list, we will miss this modifying use and may end up suggesting an invalid fix.
Instead, we should treat any use of "s" on the lhs as a modifying use.
Change-Id: I4ba58d720f2df2db3fca71927d0704cbb9e8813d
Reviewed-on: https://go-review.googlesource.com/c/tools/+/766541
Commit-Queue: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Files:
- M go/analysis/passes/modernize/stringscut.go
- M go/analysis/passes/modernize/testdata/src/stringscut/stringscut.go
- M go/analysis/passes/modernize/testdata/src/stringscut/stringscut.go.golden
Change size: S
Delta: 3 files changed, 26 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages