[go] test/codegen: tighten bit related codegen tests on riscv64

0 views

Skip to first unread message

Joel Sing (Gerrit)

unread,

6:14 AM (11 hours ago) 6:14 AM

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Julian Zhu, Meng Zhuo, Cherry Mui, Go LUCI, Mark Ryan, golang-co...@googlegroups.com

Joel Sing submitted the change

Change information

Commit message:

test/codegen: tighten bit related codegen tests on riscv64

Ensure that loading the value of one is included and specify the actual
constants for various instructions. Avoid potential ambiguity with
instructions (e.g. use "AND " to avoid matching "ANDI").

Change-Id: I42707bd68fab9e12d984670e64a02ee93667f77c

Reviewed-on: https://go-review.googlesource.com/c/go/+/748920

Reviewed-by: Julian Zhu <julia...@isrc.iscas.ac.cn>

Reviewed-by: David Chase <drc...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Meng Zhuo <mengzh...@gmail.com>

Files:

M test/codegen/bits.go

Change size: M

Delta: 1 file changed, 47 insertions(+), 47 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by David Chase, +2 by Julian Zhu, +2 by Cherry Mui, +2 by Meng Zhuo
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages