[go] cmd/trace: rewrite unspecified address to localhost in URL

0 views

Skip to first unread message

Michael Pratt (Gerrit)

unread,

Apr 24, 2026, 4:09:28 PM (17 hours ago) Apr 24

to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Damien Neil, Carlos Amedee, Michael Knyszek, golang-co...@googlegroups.com

Michael Pratt submitted the change

Change information

Commit message:

cmd/trace: rewrite unspecified address to localhost in URL

The previous CL makes -http=:6060 listen on localhost instead of all
addresses, so this case will print http://127.0.0.1:6060.

However, when user explicitly pass the unspecified address (e.g.,
-http=0.0.0.0:6060), we will print http://0.0.0.0:6060.

Clicking this link to connect unspecified address doesn't make much
sense. On Linux, the kernel happens to treat connect to the unspecified
address as a connect to loopback, so this works fine. On the other hand,
Windows treats connect to the unspecified address as an explicit error,
so this URL doesn't work.

Instead, rewrite the unspecified address to localhost when printing the
URL to ensure it works on all OSes. To avoid hiding that we are
listening all addresses, we now print the full listen address in
addition to the potentially rewritten URL.

Fixes #78921.