[go] cmd/go: add information about GODEBUGS to go help gopath

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
11:25 AM (12 hours ago) 11:25 AM
to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Matloob, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/go/alldocs.go
Insertions: 1, Deletions: 1.

@@ -2872,7 +2872,7 @@
//
// In GOPATH mode, the default GODEBUG values built into a binary
// will be those used in Go 1.20, setting the same GODEBUG values
-// as when a module specifies "godebug default=go1.20"". To use
+// as when a module specifies "godebug default=go1.20". To use
// different GODEBUG settings, the GODEBUG environment variable must
// be set to override those values. This also means that the standard
// library tests will not run properly with GO111MODULE=off.
```
```
The name of the file: src/cmd/go/internal/help/helpdoc.go
Insertions: 1, Deletions: 1.

@@ -526,7 +526,7 @@

In GOPATH mode, the default GODEBUG values built into a binary
will be those used in Go 1.20, setting the same GODEBUG values
-as when a module specifies "godebug default=go1.20"". To use
+as when a module specifies "godebug default=go1.20". To use
different GODEBUG settings, the GODEBUG environment variable must
be set to override those values. This also means that the standard
library tests will not run properly with GO111MODULE=off.
```

Change information

Commit message:
cmd/go: add information about GODEBUGs to go help gopath

And make it clear that standard library tests won't run properly with
GO111MODULE=off.

Fixes #73973
Fixes #69202
Change-Id: I8c71c739e1da80fbf2e13f84ecaf9c346a6a6964
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Michael Matloob <mat...@google.com>
Auto-Submit: Michael Matloob <mat...@google.com>
Files:
  • M src/cmd/go/alldocs.go
  • M src/cmd/go/internal/help/helpdoc.go
Change size: S
Delta: 2 files changed, 14 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Michael Matloob, +1 by Dmitri Shuralyov, +2 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I8c71c739e1da80fbf2e13f84ecaf9c346a6a6964
Gerrit-Change-Number: 758720
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages