[vscode-go] .vscode/launch.json: remove outFiles and deprecated attributes

19 views

Skip to first unread message

Hyang-Ah Hana Kim (Gerrit)

unread,

Jul 22, 2022, 2:20:56 PM7/22/22

to Hyang-Ah Hana Kim, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Jamal Carvalho, kokoro, Suzy Mueller, golang-co...@googlegroups.com

Hyang-Ah Hana Kim submitted this change.

View Change



7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: .vscode/launch.json
Insertions: 1, Deletions: 1.

@@ -64,7 +64,7 @@
 			},
 			"sourceMaps": true,
 			"smartStep": true,
-			"preLaunchTask": "npm: watch",			
+			"preLaunchTask": "npm: watch",
 		},
 		{
 			"name": "Launch Extension Tests with Gopls",
```

Approvals:
  Jamal Carvalho: Looks good to me, approved

.vscode/launch.json: remove outFiles and deprecated attributes

js/ts debugger seems to correctly infer the out files
nowadays. And the outFiles values that were in launch.json
don't work on windows.

stopOnEntry and protocol are no longer valid.

Change-Id: I064476ac6c7be941b8d757e82e04639a4e023b02
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/418549
Reviewed-by: Jamal Carvalho <ja...@golang.org>
---
M .vscode/launch.json
1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/.vscode/launch.json b/.vscode/launch.json
index ab3634d..3411a6f 100644
--- a/.vscode/launch.json
+++ b/.vscode/launch.json
@@ -22,7 +22,6 @@
 			"outFiles": [
                 "${workspaceFolder}/dist/**/*.js"
             ],
-			"stopOnEntry": false,
 			"sourceMaps": true,
 			"smartStep": true,
 			"preLaunchTask": "npm: bundle-dev",
@@ -33,7 +32,6 @@
 		{
 			"name": "Launch as server",
 			"type": "node",
-			"protocol": "inspector",
 			"request": "launch",
 			"program": "${workspaceFolder}/dist/debugAdapter.js",
 			"args": [
@@ -64,14 +62,9 @@
 				"VSCODE_GO_IN_TEST": "1",  // Disable code that shouldn't be used in test
 				"MOCHA_TIMEOUT": "999999",
 			},
-			"stopOnEntry": false,
 			"sourceMaps": true,
 			"smartStep": true,
-			"outFiles": [
-				"${workspaceFolder}/out/**/*.js",
-				"${workspaceFolder}/out/test/**/*.js"
-			],
-			"preLaunchTask": "npm: watch"
+			"preLaunchTask": "npm: watch",
 		},
 		{
 			"name": "Launch Extension Tests with Gopls",
@@ -89,12 +82,7 @@
 			"env": {
 				"VSCODE_GO_IN_TEST": "1"  // Disable code that shouldn't be used in test
 			},
-			"stopOnEntry": false,
 			"sourceMaps": true,
-			"outFiles": [
-				"${workspaceFolder}/out/**/*.js",
-				"${workspaceFolder}/out/test/**/*.js"
-			],
 			"preLaunchTask": "npm: watch",
 		},
 		{

To view, visit change 418549. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages