[tools] gopls/internal/telemetry: skip the telemetry test on Plan 9

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jun 26, 2026, 8:50:32 PM (16 hours ago) Jun 26

to David du Colombier, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hyang-Ah Hana Kim, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Richard Miller, Robert Findley, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

gopls/internal/telemetry: skip the telemetry test on Plan 9

The telemetry test relies on the counters from
golang.org/x/telemetry, which are stored in
memory-mapped files.

Plan 9 does not support mmap, so the counters are
never persisted and always read back as zero, like
on js/wasm and wasip1, which are already excluded.

Add plan9 to the build constraint.

Change-Id: I356f9d0115ace200de8c4ffa3a192ca18babeaba

Reviewed-on: https://go-review.googlesource.com/c/tools/+/794821

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: David du Colombier <0in...@gmail.com>

Reviewed-by: Hyang-Ah Hana Kim <hya...@gmail.com>

Reviewed-by: Richard Miller <millerr...@gmail.com>

Files:

M gopls/internal/telemetry/telemetry_test.go

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Dmitri Shuralyov, +2 by Richard Miller, +2 by Hyang-Ah Hana Kim
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages