[vscode-go] extension/src: update regex for parseGoVersionOutput
0 views
Skip to first unread message
Madeline Kalil (Gerrit)
Jul 24, 2026, 2:47:43 PM (2 days ago) Jul 24
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Hongxiang Jiang, golang...@luci-project-accounts.iam.gserviceaccount.com, Gopher Robot, golang-co...@googlegroups.com
Madeline Kalil submitted the change![]( "Open in Gerrit")
Change information
Commit message:
extension/src: update regex for parseGoVersionOutput
In the pickGoProcess feature, we provide an interactive
process picker to find local processes to attach to
in debug mode.
We find and filter all local processes to determine
which ones are actually Go. To do this, we run 'go version'
on the executable paths. We then attempt to match the output of 'go version'
to a regex goVersionRegexp. Currently, this regex does not match
go versions with suffixes like "rc1" or "-X:nodwarf5, so it will
not add them to the list of available processes to attach.
Update the regex to allow these suffixes so that we show
them in the pickGoProcess dropdown.
Fixes golang/vscode-go#4059
Change-Id: I612bba3a9f5fa41e29db61f92e3f48e413660e05
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Hongxiang Jiang <hxj...@golang.org>
Files:
- M extension/src/pickProcess.ts
- M extension/test/integration/pickProcess.test.ts
Change size: XS
Delta: 2 files changed, 6 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Hongxiang Jiang
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages