[vscode-go] extension/src/language: document async behavior of input collect

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Feb 9, 2026, 4:55:26 AMFeb 9

to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Peter Weinberger, Go LUCI, Madeline Kalil, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

extension/src/language: document async behavior of input collect

Because vscode allow user to execute code actions while waiting
for user input, I thought it is necessary to have a mutex so only
one interactive refactoring can be executed and others should wait.

It would be very confusing if the extension ask one question from
the first interactive refactoring and then ask one question from
the other interactive refactoring. At least, we should finish all
questions from the first interactive refactoring then move to the
second.

However, it turns out that if the user request a new interactive
refactoring, a new vscode input box would automatically cancel the
existing active input box(if any). Our extension consider a
cancelled input box as a cancellation of the entire interactive
refactoring. So the previous interactive refactoring will be canceled.
This behavior is reasonable and maybe the best.

Since there is no code change required, this CL only modifies the
comments for documentation purpose.

For golang/go#76331