[go] cmd/go/testdata/script: don't use net in mod_sumdb_file_path test

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

2:54 PM (5 hours ago) 2:54 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change

Unreviewed changes

3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go/testdata/script: don't use net in mod_sumdb_file_path test

Export the test sumdb to the test case as TESTGO_SUBDB. The test wants
to check the proxy's supported file for the sumdb, so we need the name
of the proxy's sumdb if we're going to use it. Then instead of the
supported file in the sum.golang.org directory, we can use the name of
the test sumdb instead.

For #80243

Change-Id: I24a4bd43f4e21333052d0a90271f9c966a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/795904

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Files:

M src/cmd/go/script_test.go
M src/cmd/go/testdata/script/mod_sumdb_file_path.txt

Change size: S

Delta: 2 files changed, 19 insertions(+), 23 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Dmitri Shuralyov, +1 by Michael Matloob, +2 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages