[crypto] chacha20poly1305: error out in fips140=only mode

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Dec 10, 2025, 9:07:41 AM (2 days ago) Dec 10
to Filippo Valsorda, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Roland Shoemaker, Go LUCI, Daniel McCarney, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
chacha20poly1305: error out in fips140=only mode

We don't guarantee fips140=only support in x/crypto, but
chacha20poly1305 is special in that it's vendored into the standard
library. We could wrap all the callsites, but it's more robust to
just error out at construction time.
Change-Id: I4b1e451bd250429c4c5c5b61c8b2141c6a6a6964
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Filippo Valsorda <fil...@golang.org>
Files:
  • M chacha20poly1305/chacha20poly1305.go
  • A chacha20poly1305/fips140only_compat.go
  • A chacha20poly1305/fips140only_go1.26.go
  • M chacha20poly1305/xchacha20poly1305.go
Change size: S
Delta: 4 files changed, 26 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Chase, +2 by Roland Shoemaker
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: crypto
Gerrit-Branch: master
Gerrit-Change-Id: I4b1e451bd250429c4c5c5b61c8b2141c6a6a6964
Gerrit-Change-Number: 728480
Gerrit-PatchSet: 2
Gerrit-Owner: Filippo Valsorda <fil...@golang.org>
Gerrit-Reviewer: Daniel McCarney <dan...@binaryparadox.net>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages