[tools] gopls/internal/test/marker: add optional error to typedef marker

[Hongxiang Jiang (Gerrit)]

Hongxiang Jiang submitted the change

Change information

Commit message:

gopls/internal/test/marker: add optional error to typedef marker

The typedef marker now accept optional input parameter error to
verify if the typedef returns an expected error from gopls.

Also migrate regression test for golang/go#60544 from integration
to marker test.

For golang/go#76723

Change-Id: Id5076268fb0458720693a30868e44e2cf0952395

Reviewed-on: https://go-review.googlesource.com/c/tools/+/728880

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Madeline Kalil <mka...@google.com>

Files:

• M gopls/internal/golang/type_definition.go
• M gopls/internal/test/integration/misc/definition_test.go
• M gopls/internal/test/marker/doc.go
• M gopls/internal/test/marker/marker_test.go
• A gopls/internal/test/marker/testdata/typedef/issue60544.txt
• M gopls/internal/test/marker/testdata/typedef/typedef.txt

Change size: M

Delta: 6 files changed, 50 insertions(+), 46 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Madeline Kalil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: Id5076268fb0458720693a30868e44e2cf0952395

Gerrit-Change-Number: 728880

Gerrit-PatchSet: 4

Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>