[tools] gopls/internal/cache: store analyzeSummary fields on analysisNode

0 views

Skip to first unread message

Robert Findley (Gerrit)

unread,

Apr 14, 2026, 10:49:00 AM (yesterday) Apr 14

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Alan Donovan, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Robert Findley submitted the change

Change information

Commit message:

gopls/internal/cache: store analyzeSummary fields on analysisNode

Replace analysisNode.summary with separate compiles and actions fields,
copied from the *analyzeSummary returned by runCached. The summary
itself is no longer retained, so it can be safely shared via filecache
or inFlightAnalyses without a defensive copy, and decrefPreds now nils
the node-local actions field rather than mutating a shared struct.

This lets runCached use filecache.Get with analyzeSummaryCodec.Decode
directly, caching the decoded summary in memCache like the other kinds.

Change-Id: I1c890053fef709ebe2f7da7543a0e7280b4d0b8a

Reviewed-on: https://go-review.googlesource.com/c/tools/+/764320

Reviewed-by: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Files:

M gopls/internal/cache/analysis.go

Change size: M

Delta: 1 file changed, 42 insertions(+), 47 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Alan Donovan, +1 by David Chase
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages