[tools] go/ssa: reject generic methods from RuntimeTypes

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Jun 8, 2026, 4:46:15 PM (3 days ago) Jun 8

to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Mark Freeman, Robert Griesemer, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: go/ssa/ssautil/visit.go
Insertions: 2, Deletions: 3.

@@ -76,10 +76,9 @@
 			mset := prog.MethodSets.MethodSet(T)
 			for sel := range mset.Methods() {
 				// Skip generic methods.
-				if sel.Obj().(*types.Func).Signature().TypeParams() != nil {
-					continue
+				if sel.Obj().(*types.Func).Signature().TypeParams() == nil {
+					function(prog.MethodValue(sel))
 				}
-				function(prog.MethodValue(sel))
 			}
 		}
 	}
```

Change information

Commit message:

go/ssa: reject generic methods from RuntimeTypes

This CL causes ssautil.AllFunctions and typesinternal.ForEachElement
(used by ssa.Prog.RuntimeTypes) to skip generic methods, which
now appear in the types.MethodSet.

Fixes golang/go#79901
Fixes golang/go#79600

Change-Id: I50a85fdc0eb5879007b28852fb8eccf061e90c81

Reviewed-on: https://go-review.googlesource.com/c/tools/+/788380

Reviewed-by: Mark Freeman <markf...@google.com>

Auto-Submit: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files: