[go] cmd/compile/internal/ssa: refactor some duplicate code into methods

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 30, 2025, 5:48:12 PM (yesterday) Sep 30
to Youlin Feng, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Keith Randall, Keith Randall, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/compile/internal/ssa: remove redundant "type:" prefix check

Remove redundant "type:" prefix check on symbol names in isFixedLoad,
also refactor some duplicate code into methods.
Change-Id: I8358422596eea8c39d1a30a554bd0aae8b570038
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Keith Randall <k...@golang.org>
Reviewed-by: Carlos Amedee <car...@golang.org>
Files:
  • M src/cmd/compile/internal/ssa/rewrite.go
  • M src/cmd/internal/obj/link.go
Change size: S
Delta: 2 files changed, 25 insertions(+), 13 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Keith Randall, +1 by Keith Randall, +1 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I8358422596eea8c39d1a30a554bd0aae8b570038
Gerrit-Change-Number: 701275
Gerrit-PatchSet: 6
Gerrit-Owner: Youlin Feng <fengy...@live.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Youlin Feng <fengy...@live.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages