[go] cmd/go: include simd bridge package in compiled test imports
0 views
Skip to first unread message
Junyang Shao (Gerrit)
Jun 8, 2026, 2:22:15 PM (3 days ago) Jun 8
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, David Chase, Michael Matloob, golang-co...@googlegroups.com
Junyang Shao submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/go: include simd bridge package in compiled test imports
It looks like a missing logic which breaks a very simple hello world
simd program. To reproduce: create a new directory, `go mod init main`,
write a very simple main.go that imports simd/archsimd, and then open
it with vscode+gopls, then cmd/go will panic:
Error loading workspace: packages.Load error: err: exit status 2: stderr: panic: runtime error: index out of range [0] with length 0
This CL fixes that.
Change-Id: I03706a12dd0d8e2351494abe95265e4fc7672e48
Reviewed-on: https://go-review.googlesource.com/c/go/+/788281
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
- M src/cmd/go/internal/load/test.go
Change size: S
Delta: 1 file changed, 36 insertions(+), 10 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by David Chase
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Chase (Gerrit)
Jun 8, 2026, 4:29:29 PM (3 days ago) Jun 8
to Junyang Shao, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
David Chase submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[dev.simd] cmd/go: include simd bridge package in compiled test imports
It looks like a missing logic which breaks a very simple hello world
simd program. To reproduce: create a new directory, `go mod init main`,
write a very simple main.go that imports simd/archsimd, and then open
it with vscode+gopls, then cmd/go will panic:
Error loading workspace: packages.Load error: err: exit status 2: stderr: panic: runtime error: index out of range [0] with length 0
This CL fixes that.
Cherry pick of CL 788281
Change-Id: I03706a12dd0d8e2351494abe95265e4fc7672e48
Reviewed-on: https://go-review.googlesource.com/c/go/+/788281
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drc...@google.com>
(cherry picked from commit a79201bad3812bc4088b397feffe8802c60116fa)
Reviewed-on: https://go-review.googlesource.com/c/go/+/788360
Reviewed-by: Junyang Shao <shaoj...@google.com>
Files:
- M src/cmd/go/internal/load/test.go
Change size: S
Delta: 1 file changed, 36 insertions(+), 10 deletions(-)
Branch: refs/heads/dev.simd
Submit Requirements:
Code-Review: +2 by Junyang Shao
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages