[go] runtime: simplify pprof labels in tracebacks

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

runtime: simplify pprof labels in tracebacks

Per discussion on #76349, move the traceback labels outside the
goroutine status block and remove the quoting if the key and value
strings are completely ASCII alphanumeric.

Also allow [._/] because those are generally benign and may show up in
a lot of use-cases if these goroutine labels become more visible.

Updates #76349

Change-Id: I338e18d7ca48bbc7504f7c699f17adade2d291f9

Reviewed-on: https://go-review.googlesource.com/c/go/+/742580

Reviewed-by: Michael Pratt <mpr...@google.com>

Reviewed-by: Florian Lehner <lehner.f...@gmail.com>

Auto-Submit: Michael Pratt <mpr...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files:

• M src/runtime/traceback.go
• M src/runtime/traceback_test.go

Change size: S

Delta: 2 files changed, 37 insertions(+), 10 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Florian Lehner, +2 by Alan Donovan, +2 by Michael Pratt
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I338e18d7ca48bbc7504f7c699f17adade2d291f9

Gerrit-Change-Number: 742580

Gerrit-PatchSet: 8

Gerrit-Owner: David Finkel <david....@gmail.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Florian Lehner <lehner.f...@gmail.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>