[go] Revert "cmd/compile: speedup large synthetic init function compile time"

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

10:32 AM (6 hours ago) 10:32 AM

to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, golang...@luci-project-accounts.iam.gserviceaccount.com, Cuong Manh Le, Russ Cox, Keith Randall, Keith Randall, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

Revert "cmd/compile: speedup large synthetic init function compile time"

This reverts CL 795261.

Reason for revert: Causing failures on perf builders due to map initialization issues in CockroachDB.

Updates #80141
Updates #77153
Fixes #80423

Change-Id: I365f20eec2220894923d4748d730484f6e6ef5c7

Reviewed-on: https://go-review.googlesource.com/c/go/+/802120

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Cuong Manh Le <cuong.m...@gmail.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Michael Pratt <mpr...@google.com>

Files:

M src/cmd/compile/internal/noder/reader.go
M src/cmd/compile/internal/pkginit/init.go
M src/cmd/compile/internal/staticinit/sched.go
D test/fixedbugs/issue80141.go

Change size: XL

Delta: 4 files changed, 14 insertions(+), 1101 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Cuong Manh Le, +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages