[tools] gopls/internal/mcp: fix reporting in go_diagnostics tool
0 views
Skip to first unread message
Madeline Kalil (Gerrit)
Jun 8, 2026, 2:55:00 PM (2 days ago) Jun 8
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, golang...@luci-project-accounts.iam.gserviceaccount.com, Hongxiang Jiang, golang-co...@googlegroups.com
Madeline Kalil submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/mcp: fix reporting in go_diagnostics tool
The go_diagnostics tool reports parse and build errors
across the entire workspace. If an array of files
is provided, it reports additional diagnostics (i.e. quick
fixes and go/analysis findings).
The additional diagnostic reporting is broken when
the tool input has more than one file because we
always use the uri of the first file in the input array.
If the input is ["a.go", "b.go"], diagnostics for "b.go"
are reported as coming from "a.go".
Use the correct uri for the diagnostic and add
tests to verify that diagnostics are reported
with the correct file.
Fixes golang/go#79892
Change-Id: I76c506377cdf05ed0e86a799c00085f286701923
Reviewed-on: https://go-review.googlesource.com/c/tools/+/788180
Reviewed-by: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M gopls/internal/mcp/workspace_diagnostics.go
- M gopls/internal/test/marker/testdata/mcptools/workspace_diagnostics.txt
Change size: S
Delta: 2 files changed, 38 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages