[go] cmd/link: don't run TestExtLinkCmdlineDeterminism in parallel with other tests

[Cherry Mui (Gerrit)]

Cherry Mui submitted the change

Change information

Commit message:

cmd/link: don't run TestExtLinkCmdlineDeterminism in parallel with other tests

Based on the investigation of #78180, it appears that for
different runs the go command picks up different object from the
build cache for the runtime/cgo package. One possible situation
could be that as the test runs in parallel with other tests, some
other test builds runtime/cgo at same time, and somehow that build
is not deterministic, causes different objects of runtime/cgo
being written to the build cache. Let's see if running the test
not in parallel helps. The test process may still run in parallel
with other processes, which could also build runtime/cgo and
interfere, so this may be just best effort. If the build of
runtime/cgo is deterministic, this shouldn't be necessary.

For #78180.

Change-Id: If078f141febd33f063fe2d564c4150223a9784ef

Reviewed-on: https://go-review.googlesource.com/c/go/+/759122

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

Files:

• M src/cmd/link/link_test.go

Change size: XS

Delta: 1 file changed, 0 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Michael Pratt
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: If078f141febd33f063fe2d564c4150223a9784ef

Gerrit-Change-Number: 759122

Gerrit-PatchSet: 2

Gerrit-Owner: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>