[tools] gopls/internal/settings: move file watcher setting to user options
0 views
Skip to first unread message
Hongxiang Jiang (Gerrit)
May 11, 2026, 4:58:03 PM (7 hours ago) May 11
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com
Hongxiang Jiang submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/settings: move file watcher setting to user options
When a setting is internal options, they can be set by the user
but it is generally very hard to discover unless the user look at
the release note or the gopls's code base.
Moving from internal setting to user setting improves the
setting's discoverability.
For golang/go#67995
Change-Id: Icd06e1321ea873dbd82f41b8a2e9da606ed35c80
Reviewed-on: https://go-review.googlesource.com/c/tools/+/776882
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Reviewed-by: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M gopls/doc/settings.md
- M gopls/internal/doc/api.json
- M gopls/internal/settings/default.go
- M gopls/internal/settings/settings.go
Change size: M
Delta: 4 files changed, 65 insertions(+), 12 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages