[tools] internal/test/marker: skip basiclit.txt on ppc64

Skip to first unread message

Robert Findley (Gerrit)

May 17, 2024, 12:36:39 PMMay 17
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Peter Weinberger, Go LUCI, golang-co...@googlegroups.com

Robert Findley submitted the change

Change information

Commit message:
internal/test/marker: skip basiclit.txt on ppc64

This test was flaking in a bizarre manner on the aix-ppc64 builder. The
x/text/unicode/runenames package apparently returns a different name for

Since aix-ppc64 is not a first class port, skip to de-flake. However,
the failure mode is so bizarre that I added a unit test in the golang
package to try to reproduce the bug using only the x/text module. If
this new unit test also flakes, I will file a bug against aix-ppc64 and

Fixes golang/go#65072
Change-Id: I99a6b60c7fd31b474e0b670e6f26e550de176ba8
Reviewed-by: Peter Weinberger <p...@google.com>
  • A gopls/internal/golang/hover_test.go
  • M gopls/internal/test/marker/marker_test.go
  • M gopls/internal/test/marker/testdata/hover/basiclit.txt
Change size: S
Delta: 3 files changed, 28 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Peter Weinberger
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I99a6b60c7fd31b474e0b670e6f26e550de176ba8
Gerrit-Change-Number: 586260
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Findley <rfin...@google.com>
Gerrit-Reviewer: Peter Weinberger <p...@google.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
Reply all
Reply to author
0 new messages