Gopher Robot (Gerrit)

unread,

Jan 15, 2026, 1:14:30 PM (3 days ago) Jan 15

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

[release-branch.go1.24] archive/zip: reduce CPU usage in index construction

Constructing the zip index (which is done once when first opening
a file in an archive) can consume large amounts of CPU when
processing deeply-nested directory paths.

Switch to a less inefficient algorithm.

Thanks to Jakub Ciolek for reporting this issue.

	goos: darwin
	goarch: arm64
	pkg: archive/zip
	cpu: Apple M4 Pro
	                          │  /tmp/bench.0  │            /tmp/bench.1            │
	                          │     sec/op     │   sec/op     vs base               │
	ReaderOneDeepDir-14         25983.62m ± 2%   46.01m ± 2%  -99.82% (p=0.000 n=8)
	ReaderManyDeepDirs-14          16.221 ± 1%    2.763 ± 6%  -82.96% (p=0.000 n=8)
	ReaderManyShallowFiles-14      130.3m ± 1%   128.8m ± 2%   -1.20% (p=0.003 n=8)
	geomean                         3.801        253.9m       -93.32%

Fixes #77102
Fixes CVE-2025-61728

Change-Id: I2c9c864be01b2a2769eb67fbab1b250aeb8f6c42

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3060

Reviewed-by: Nicholas Husin <hu...@google.com>

Reviewed-by: Neal Patel <neal...@google.com>

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3328

Reviewed-by: Damien Neil <dn...@google.com>

Reviewed-on: https://go-review.googlesource.com/c/go/+/736703

TryBot-Bypass: Michael Pratt <mpr...@google.com>

Auto-Submit: Michael Pratt <mpr...@google.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Files:

M src/archive/zip/reader.go
M src/archive/zip/reader_test.go

Change size: M

Delta: 2 files changed, 91 insertions(+), 1 deletion(-)

Branch: refs/heads/release-branch.go1.24

Submit Requirements:

Code-Review: +2 by Junyang Shao
TryBots-Pass: TryBot-Bypass+1 by Michael Pratt

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Gopher Robot (Gerrit)

unread,

Jan 15, 2026, 1:14:46 PM (3 days ago) Jan 15

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

[release-branch.go1.26] archive/zip: reduce CPU usage in index construction



Constructing the zip index (which is done once when first opening
a file in an archive) can consume large amounts of CPU when
processing deeply-nested directory paths.

Switch to a less inefficient algorithm.

Thanks to Jakub Ciolek for reporting this issue.

	goos: darwin
	goarch: arm64
	pkg: archive/zip
	cpu: Apple M4 Pro
	                          │  /tmp/bench.0  │            /tmp/bench.1            │
	                          │     sec/op     │   sec/op     vs base               │
	ReaderOneDeepDir-14         25983.62m ± 2%   46.01m ± 2%  -99.82% (p=0.000 n=8)
	ReaderManyDeepDirs-14          16.221 ± 1%    2.763 ± 6%  -82.96% (p=0.000 n=8)
	ReaderManyShallowFiles-14      130.3m ± 1%   128.8m ± 2%   -1.20% (p=0.003 n=8)
	geomean                         3.801        253.9m       -93.32%

Fixes #77102
Fixes CVE-2025-61728

Change-Id: I2c9c864be01b2a2769eb67fbab1b250aeb8f6c42

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3060

Reviewed-by: Nicholas Husin <hu...@google.com>

Reviewed-by: Neal Patel <neal...@google.com>

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3346

Reviewed-by: Damien Neil <dn...@google.com>

Reviewed-on: https://go-review.googlesource.com/c/go/+/736708

Auto-Submit: Michael Pratt <mpr...@google.com>

TryBot-Bypass: Michael Pratt <mpr...@google.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Files:

M src/archive/zip/reader.go
M src/archive/zip/reader_test.go

Change size: M

Delta: 2 files changed, 91 insertions(+), 1 deletion(-)

Branch: refs/heads/release-branch.go1.26

Submit Requirements:

Code-Review: +2 by Junyang Shao
TryBots-Pass: TryBot-Bypass+1 by Michael Pratt

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Gopher Robot (Gerrit)

unread,

Jan 15, 2026, 1:15:06 PM (3 days ago) Jan 15

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

[release-branch.go1.25] archive/zip: reduce CPU usage in index construction



Constructing the zip index (which is done once when first opening
a file in an archive) can consume large amounts of CPU when
processing deeply-nested directory paths.

Switch to a less inefficient algorithm.

Thanks to Jakub Ciolek for reporting this issue.

	goos: darwin
	goarch: arm64
	pkg: archive/zip
	cpu: Apple M4 Pro
	                          │  /tmp/bench.0  │            /tmp/bench.1            │
	                          │     sec/op     │   sec/op     vs base               │
	ReaderOneDeepDir-14         25983.62m ± 2%   46.01m ± 2%  -99.82% (p=0.000 n=8)
	ReaderManyDeepDirs-14          16.221 ± 1%    2.763 ± 6%  -82.96% (p=0.000 n=8)
	ReaderManyShallowFiles-14      130.3m ± 1%   128.8m ± 2%   -1.20% (p=0.003 n=8)
	geomean                         3.801        253.9m       -93.32%

Fixes #77102
Fixes CVE-2025-61728

Change-Id: I2c9c864be01b2a2769eb67fbab1b250aeb8f6c42

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3060

Reviewed-by: Nicholas Husin <hu...@google.com>

Reviewed-by: Neal Patel <neal...@google.com>

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3327

Reviewed-by: Damien Neil <dn...@google.com>

Reviewed-on: https://go-review.googlesource.com/c/go/+/736724

TryBot-Bypass: Michael Pratt <mpr...@google.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Auto-Submit: Michael Pratt <mpr...@google.com>

Files:

M src/archive/zip/reader.go
M src/archive/zip/reader_test.go

Change size: M

Delta: 2 files changed, 91 insertions(+), 1 deletion(-)

Branch: refs/heads/release-branch.go1.25

Submit Requirements:

Code-Review: +2 by Junyang Shao
TryBots-Pass: TryBot-Bypass+1 by Michael Pratt

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Gopher Robot (Gerrit)

unread,

Jan 15, 2026, 1:36:01 PM (3 days ago) Jan 15

to Michael Pratt, Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Junyang Shao, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

archive/zip: reduce CPU usage in index construction



Constructing the zip index (which is done once when first opening
a file in an archive) can consume large amounts of CPU when
processing deeply-nested directory paths.

Switch to a less inefficient algorithm.

Thanks to Jakub Ciolek for reporting this issue.

	goos: darwin
	goarch: arm64
	pkg: archive/zip
	cpu: Apple M4 Pro
	                          │  /tmp/bench.0  │            /tmp/bench.1            │
	                          │     sec/op     │   sec/op     vs base               │
	ReaderOneDeepDir-14         25983.62m ± 2%   46.01m ± 2%  -99.82% (p=0.000 n=8)
	ReaderManyDeepDirs-14          16.221 ± 1%    2.763 ± 6%  -82.96% (p=0.000 n=8)
	ReaderManyShallowFiles-14      130.3m ± 1%   128.8m ± 2%   -1.20% (p=0.003 n=8)
	geomean                         3.801        253.9m       -93.32%

Fixes #77102
Fixes CVE-2025-61728

Change-Id: I2c9c864be01b2a2769eb67fbab1b250aeb8f6c42

Reviewed-on: https://go-internal-review.googlesource.com/c/go/+/3060

Reviewed-by: Nicholas Husin <hu...@google.com>

Reviewed-by: Neal Patel <neal...@google.com>

Reviewed-on: https://go-review.googlesource.com/c/go/+/736713

Auto-Submit: Michael Pratt <mpr...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Junyang Shao <shaoj...@google.com>

Files:

M src/archive/zip/reader.go
M src/archive/zip/reader_test.go

Change size: M

Delta: 2 files changed, 91 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Junyang Shao

TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

[go/release-branch.go1.24] [release-branch.go1.24] archive/zip: reduce CPU usage in index construction

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information

Gopher Robot (Gerrit)

Gopher Robot submitted the change

Change information