[go] crypto: clean up subprocess-spawning tests
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Dec 10, 2025, 4:46:09 PM (2 days ago) Dec 10
to Filippo Valsorda, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Roland Shoemaker, Go LUCI, Daniel McCarney, Kevin Burke, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
crypto: clean up subprocess-spawning tests
Consistently use testenv.Command and testenv.Executable, avoid redundant
testenv.Must, use testenv.CleanCmdEnv where the output is parsed, always
log the output with a preceding newline, invoke tests with -v, and
always use cmd.Environ() to preserve existing env.
Change-Id: I647ff1a8b7d162e5e8df9424030fac446a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/728641
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
Auto-Submit: Filippo Valsorda <fil...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M src/crypto/cipher/gcm_fips140v2.0_test.go
- M src/crypto/cipher/gcm_test.go
- M src/crypto/ecdh/ecdh_test.go
- M src/crypto/fips140/enforcement_test.go
- D src/crypto/fips140/testdata/enforcement_test.go
- M src/crypto/internal/cryptotest/fetchmodule.go
- M src/crypto/internal/fips140deps/fipsdeps_test.go
- M src/crypto/internal/fips140test/acvp_test.go
- M src/crypto/internal/fips140test/cast_test.go
- M src/crypto/internal/fips140test/check_test.go
- M src/crypto/internal/sysrand/rand_linux_test.go
- M src/crypto/internal/sysrand/rand_test.go
- M src/crypto/purego_test.go
- M src/crypto/rand/rand_test.go
- M src/crypto/tls/bogo_shim_test.go
- M src/crypto/tls/link_test.go
- M src/crypto/x509/bettertls_test.go
- M src/crypto/x509/name_constraints_test.go
- M src/crypto/x509/root_linux_test.go
- M src/crypto/x509/x509_test.go
Change size: L
Delta: 20 files changed, 122 insertions(+), 185 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Daniel McCarney, +1 by Dmitri Shuralyov, +1 by Roland Shoemaker
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages