[go] Revert "cmd/compile: optimize abi.Type.TFlag loads"

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
12:19 PM (4 hours ago) 12:19 PM
to Jake Bailey, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Keith Randall, Keith Randall, Russ Cox, t hepudds, golang-co...@googlegroups.com

Gopher Robot submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Revert "cmd/compile: optimize abi.Type.TFlag loads"

This reverts CL 701299 (commit 86eb9afa8c7dbab5180c618d63c3e5fc09bc13dc).

Reason for revert: broke relui compile

Fixes #80450
Change-Id: Icdad4b66c5a95df6d936f8280496d53fefea4631
Reviewed-by: Keith Randall <k...@golang.org>
Auto-Submit: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Keith Randall <k...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M src/cmd/compile/internal/reflectdata/reflect.go
  • M src/cmd/compile/internal/ssa/rewrite.go
  • M src/cmd/compile/internal/typecheck/subr.go
  • D src/cmd/compile/internal/types/tflag.go
  • M src/cmd/compile/internal/types/type.go
Change size: M
Delta: 5 files changed, 29 insertions(+), 98 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icdad4b66c5a95df6d936f8280496d53fefea4631
Gerrit-Change-Number: 802140
Gerrit-PatchSet: 3
Gerrit-Owner: Jake Bailey <jacob.b...@gmail.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Russ Cox <r...@golang.org>
Gerrit-CC: t hepudds <thepud...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages