[go] net/http: fix BenchmarkClientRequestHeaders/1000_Headers with the new Server.MaxHeaderValueCount

2 views

Skip to first unread message

Emmanuel Odeke (Gerrit)

unread,

Jul 2, 2026, 10:18:39 AM (2 days ago) Jul 2

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, Dmitri Shuralyov, Dmitri Shuralyov, Damien Neil, golang-co...@googlegroups.com

Emmanuel Odeke submitted the change

Change information

Commit message:

net/http: fix BenchmarkClientRequestHeaders header count failure

After CL 795460, a couple of longtest builders got broken because
the max header value count for incoming requests was set by default
to 500, yet the subject benchmark operates on 1,000 headers so this
change simply gives it more breathing space by 30+nheaders.

Updates #79936
Fixes #80230

Change-Id: I0ab8a699be062ca967d090a070b803d8137453f1

Reviewed-on: https://go-review.googlesource.com/c/go/+/796520

Reviewed-by: Nicholas Husin <hu...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Auto-Submit: Emmanuel Odeke <emma...@orijtech.com>

Reviewed-by: Nicholas Husin <n...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/net/http/internal/http2/transport_test.go

Change size: XS

Delta: 1 file changed, 5 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Dmitri Shuralyov, +2 by Nicholas Husin, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages