[pkgsite] internal/breakings/tri: 3-valued bool

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Aug 10, 2026, 5:36:21 PM (12 hours ago) Aug 10

to Jonathan Amsterdam, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, kokoro, golang...@luci-project-accounts.iam.gserviceaccount.com, Ethan Lee, Hyang-Ah Hana Kim, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: internal/breakings/tri/tribool.go
Insertions: 2, Deletions: 2.

@@ -78,7 +78,7 @@
 		}
 		return Maybe
 	default:
-		panic("bad tri.Bool")
+		panic(fmt.Sprintf("bad tri.Bool: %+v", t1))
 	}
 }
 
@@ -93,7 +93,7 @@
 	case Maybe:
 		return Maybe
 	default:
-		panic("bad tri.Bool")
+		panic(fmt.Sprintf("bad tri.Bool: %+v", t))
 	}
 }
 
```

Change information

Commit message:

internal/breakings/tri: 3-valued bool

This is the first CL in a series that implements a signal for breaking
changes. The readme provides a roadmap for the eventual structure of
this directory. The CLs build the structure from the bottom up. We start
with a three valued boolean, which is needed to reflect the fact that
detecting breaking changes with syntax is necessarily imprecise: we
can't always know for sure if a change is a breaking one without type
information.

For golang/go#80385.

Change-Id: I98d93a278238dc8ce8713eca1812834126af8258

Reviewed-on: https://go-review.googlesource.com/c/pkgsite/+/811380

Auto-Submit: Jonathan Amsterdam <j...@google.com>

Reviewed-by: Ethan Lee <etha...@google.com>

kokoro-CI: kokoro <noreply...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

A internal/breakings/README.md
A internal/breakings/tri/tribool.go
A internal/breakings/tri/tribool_test.go

Change size: L

Delta: 3 files changed, 313 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Ethan Lee
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
kokoro-CI-Passes: kokoro-CI+1 by kokoro

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages