[go] cmd/compile/internal/ssa: don't by pass Func.Fatalf in Value.Fatalf

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Aug 10, 2026, 5:03:35 PM (13 hours ago) Aug 10

to Arseny Samoylov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Matloob, Michael Matloob, Keith Randall, Keith Randall, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile/internal/ssa: don't by pass Func.Fatalf in Value.Fatalf

Func.FatalF wraps fronted Fatalf call with a cleanup (that currently flushing the GOSSAFUNC html writer).
Previously Value.FatalF call bypassed this wrapper by calling the fronted directly.

Also, a small cleanup after CL 804260

Change-Id: Iee99516f8056d4beffdca79fe808db3c413b3686

Reviewed-on: https://go-review.googlesource.com/c/go/+/811360

Reviewed-by: Michael Matloob <mat...@golang.org>

Auto-Submit: Keith Randall <k...@golang.org>

Reviewed-by: Keith Randall <k...@google.com>

Reviewed-by: Keith Randall <k...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Files:

M src/cmd/compile/internal/ssa/block.go
M src/cmd/compile/internal/ssa/func.go
M src/cmd/compile/internal/ssa/html.go
M src/cmd/compile/internal/ssa/value.go

Change size: S

Delta: 4 files changed, 8 insertions(+), 7 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Michael Matloob, +2 by Keith Randall, +1 by Keith Randall, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages