[build] internal/relui, internal/task: keep parent PATH, add skip if no python3
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Apr 16, 2025, 3:58:11 PM4/16/25
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Go LUCI, Michael Knyszek, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/relui, internal/task: keep parent PATH, add skip if no python3
Improve the ability of tests to run in more environments. In the general
case, it's not viable to assume that replacing the parent environment's
PATH with '/bin:/usr/bin' will work, it can cause some commands like git
to be in PATH (defeating the t.Skip) yet its sub-commands can break.
Also add a missing skip when python3 isn't in PATH, since makeScript has
it as a dependency.
For golang/go#61112.
Change-Id: I623ed400c2f93c86f53e20ea7d7bfe04aefc2596
Cq-Include-Trybots: luci.golang.try:x_build-gotip-linux-amd64_debiansid
Reviewed-on: https://go-review.googlesource.com/c/build/+/666035
Reviewed-by: Michael Pratt <mpr...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/relui/buildrelease_test.go
- M internal/task/fakes.go
Change size: S
Delta: 2 files changed, 10 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Pratt, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages