[go] go/doc: reuse import name logic for examples

0 views
Skip to first unread message

David Chase (Gerrit)

unread,
Dec 12, 2025, 12:04:50 PM (4 days ago) Dec 12
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Alan Donovan, Jonathan Amsterdam, Robert Findley, Go LUCI, golang-co...@googlegroups.com

David Chase submitted the change

Change information

Commit message:
go/doc: reuse import name logic for examples

Examples resolved imports based on just the path name,
but this doesn't work for go-name or modules on v2+.

Updates #12794
Fixes #45110
Fixes #56740
Fixes #62059
Change-Id: I8c71b1e5311df04bccbdf319d759d3176a6a6964
Reviewed-by: Alan Donovan <adon...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M src/go/doc/example.go
  • A src/go/doc/testdata/examples/major_version.go
  • A src/go/doc/testdata/examples/major_version.golden
Change size: S
Delta: 3 files changed, 30 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan, +1 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I8c71b1e5311df04bccbdf319d759d3176a6a6964
Gerrit-Change-Number: 728280
Gerrit-PatchSet: 2
Gerrit-Owner: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-CC: Jonathan Amsterdam <j...@google.com>
Gerrit-CC: Robert Findley <rfin...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages