[go] internal/cpu: use IsProcessorFeaturePresent to calculate ARM64 on windows

0 views
Skip to first unread message

Alex Brainman (Gerrit)

unread,
1:38 AM (2 hours ago) 1:38 AM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, David Chase, Quim Muntal, Brad Fitzpatrick, Keith Randall, Martin Möhrmann, Gopher Robot, Go LUCI, golang-co...@googlegroups.com

Alex Brainman submitted the change

Change information

Commit message:
internal/cpu: use IsProcessorFeaturePresent to calculate ARM64 on windows

This CL also adds internal/syscall/windows.IsProcessorFeaturePresent
and all processor feature consts to test internal/cpu changes.

For #76791
Change-Id: Iba9cc812f676b700e767a1ed7f194fcb4a67f61b
Cq-Include-Trybots: luci.golang.try:gotip-windows-arm64
Reviewed-by: Quim Muntal <quimm...@gmail.com>
Reviewed-by: Mark Freeman <markf...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M src/internal/cpu/cpu_arm64_other.go
  • A src/internal/cpu/cpu_arm64_windows.go
  • A src/internal/cpu/cpu_windows.go
  • A src/internal/cpu/cpu_windows_test.go
  • M src/internal/syscall/windows/syscall_windows.go
  • M src/internal/syscall/windows/types_windows.go
  • M src/internal/syscall/windows/zsyscall_windows.go
  • M src/runtime/os_windows.go
Change size: M
Delta: 8 files changed, 203 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Quim Muntal, +1 by David Chase, +1 by Mark Freeman
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Iba9cc812f676b700e767a1ed7f194fcb4a67f61b
Gerrit-Change-Number: 745560
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>
Gerrit-CC: Gopher Robot <go...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages