[go] cmd/compile: don't inline runtime functions in -d=checkptr build

0 views

Skip to first unread message

Cherry Mui (Gerrit)

unread,

11:45 AM (7 hours ago) 11:45 AM

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, Keith Randall, Cuong Manh Le, golang-co...@googlegroups.com

Cherry Mui submitted the change with unreviewed changes

Unreviewed changes

2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/cmd/internal/objabi/pkgspecial.go
Insertions: 2, Deletions: 0.

@@ -18,6 +18,8 @@
 	//
 	// - Optimizations are always enabled.
 	//
+	// - Checkptr is always disabled.
+	//
 	// This should be set for runtime and all packages it imports, and may be
 	// set for additional packages.
 	Runtime bool
```

Change information

Commit message:

cmd/compile: don't inline runtime functions in -d=checkptr build

Runtime functions, e.g. internal/abi.NoEscape, should not be
instrumented with checkptr. But if they are inlined into a
checkptr-enabled function, they will be instrumented, and may
result in a check failure.

Let the compiler not inline runtime functions into checkptr-
enabled functions.

Also undo the change in the strings package in CL 598295, as the
compiler handles it now.

Fixes #68511.
Updates #68415.

Change-Id: I78eb380855ac9dd53c1a1a628ec0da75c3e5a1a0

Reviewed-on: https://go-review.googlesource.com/c/go/+/599435

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-by: Cuong Manh Le <cuong.m...@gmail.com>

Reviewed-by: Keith Randall <k...@google.com>

Files: