[go] time: skip test that will fail with GO111MODULE=off
0 views
Skip to first unread message
Kevin Burke (Gerrit)
Dec 23, 2025, 3:51:48 PM (2 days ago) Dec 23
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Roland Shoemaker, Nicholas Husin, Michael Knyszek, Russ Cox, Gopher Robot, golang-co...@googlegroups.com
Kevin Burke submitted the change![]( "Open in Gerrit")
Change information
Commit message:
time: skip test that will fail with GO111MODULE=off
The test is designed to ensure that behavior introduced in Go 1.23
to garbage collect async timed channels is working correctly. If
GO111MODULE=off is set (or GODEBUG=asynctimerchan=1) Go reverts to the
Go 1.20 behavior of not garbage collecting these channels, which fails
the test.
Instead of running a test in conditions where we know it will fail,
just skip the test. A more comprehensive test does not make sense
right now because this code may go away soon.
Fixes #76948.
Change-Id: Ib186abd2ea583a06b5c246bfd6df932522cf7f1e
Reviewed-on: https://go-review.googlesource.com/c/go/+/732100
Reviewed-by: Nicholas Husin <hu...@google.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/time/export_test.go
- M src/time/tick_test.go
Change size: XS
Delta: 2 files changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Knyszek, +1 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages