[tools] go/analysis/passes/modernize: avoid changing assignment-form slicesbackward loops
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Aug 14, 2026, 4:01:49 PM (2 days ago) Aug 14
to shuang cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Madeline Kalil, Peter Weinberger, golang...@luci-project-accounts.iam.gserviceaccount.com, Alan Donovan, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
go/analysis/passes/modernize: avoid changing assignment-form slicesbackward loops
The slicesbackward analyzer must not rewrite loops whose init statement
assigns to a pre-existing variable. Replacing
for i = len(s)-1; i >= 0; i-- {}
with a range loop declares a new iteration variable and changes the
value observed after the loop.
Only offer the suggested fix for := initialization, and add a regression test.
Fixes golang/go#80832 and golang/go#80838
Change-Id: I381a9f373ede43b097dac177cd01b86915d1282f
Reviewed-on: https://go-review.googlesource.com/c/tools/+/813700
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Madeline Kalil <mka...@google.com>
Auto-Submit: Madeline Kalil <mka...@google.com>
Reviewed-by: Peter Weinberger <p...@google.com>
Files:
- M go/analysis/passes/modernize/slicesbackward.go
- M go/analysis/passes/modernize/testdata/src/slicesbackward/slicesbackward.go
- M go/analysis/passes/modernize/testdata/src/slicesbackward/slicesbackward.go.golden
Change size: S
Delta: 3 files changed, 32 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Peter Weinberger, +2 by Madeline Kalil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages