[tools] gopls/internal/protocol: make *UnmarshalError implement error
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jun 25, 2026, 4:14:36 PM (2 days ago) Jun 25
to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
gopls/internal/protocol: make *UnmarshalError implement error
Previously, both UnmarshalError and *UnmarshalError implemented
error, which creates ambiguity for the user trying to match
using errors.Is. This change removes the ambiguity.
Change-Id: Ifb97015536fefecefc94f42764914636827be642
Reviewed-on: https://go-review.googlesource.com/c/tools/+/794440
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Reviewed-by: Michael Pratt <mpr...@google.com>
Files:
- M gopls/internal/protocol/generate/main.go
- M gopls/internal/protocol/tsjson.go
Change size: S
Delta: 2 files changed, 6 insertions(+), 5 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages