[go/release-branch.go1.25] [release-branch.go1.25] cmd/go: specify full path to go command when running go tool covdata

0 views

Skip to first unread message

Carlos Amedee (Gerrit)

unread,

Apr 23, 2026, 4:25:48 PM (2 days ago) Apr 23

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, golang...@luci-project-accounts.iam.gserviceaccount.com, Michael Matloob, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:

[release-branch.go1.25] cmd/go: specify full path to go command when running go tool covdata

Otherwise the GOROOT will be a post-1.25 GOROOT, while we try to run
"go tool covdata" with a go command that's 1.24 or earlier from the post
1.25 toolchain. The 1.24 go command won't be able to find covdata in the
1.25 goroot because go 1.25 and later don't ship with a prebuilt covdata
tool.

For #71867
For #75031
Fixes #78411

Change-Id: I770f10a288347ac33cf721d34a2adb1a6a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/756220
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
(cherry picked from commit 90adad7b2565d456bf5e120a59a07ff31f3ada45)
Reviewed-on: https://go-review.googlesource.com/c/go/+/760306
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/cmd/go/internal/work/cover.go
A src/cmd/go/testdata/script/cover_switch_toolchain.txt

Change size: S

Delta: 2 files changed, 13 insertions(+), 1 deletion(-)

Branch: refs/heads/release-branch.go1.25

Submit Requirements:

Code-Review: +1 by Michael Matloob, +2 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement