[build] devapp: build Docker image via Cloud Build instead of local Docker
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Jan 20, 2026, 3:57:15 PM (2 days ago) Jan 20
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Carlos Amedee, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
devapp: build Docker image via Cloud Build instead of local Docker
In CL 707295 I missed the devapp service. Migrate it too.
devapp differs from all other deployed services in x/build by not living
in the cmd directory. The deploy/cloudbuild-from-googlesource.yaml file
expects to find a Dockerfile at cmd/{service-name}/Dockerfile, which
won't work as is. Instead of making that file more complicated by adding
support for this edge case, start moving devapp into cmd for consistency
with other deployed x/build services. This CL moves only the deployment
files, leaving the rest of the move for a separate CL.
For golang/go#70913.
Change-Id: Ia246c2c92b4efc297b9801eb4fae35ee81563c66
Reviewed-on: https://go-review.googlesource.com/c/build/+/737060
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Files:
- R cmd/devapp/Dockerfile
- R cmd/devapp/Makefile
- R cmd/devapp/deployment-prod.yaml
- R cmd/devapp/deployment-staging.yaml
- R cmd/devapp/service-staging.yaml
- M devapp/README.md
Change size: S
Delta: 6 files changed, 9 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Carlos Amedee, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages