[pkgsite] internal/api: refactor error handling to increase consistency
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Apr 9, 2026, 4:23:09 PM (11 hours ago) Apr 9
to Ethan Lee, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Jonathan Amsterdam, kokoro, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/api: refactor error handling to increase consistency
- Refactored error handling to avoid leaking internal implementation
details. Database and system errors are masked by falling back to
standard HTTP statuses but still logging the entire error context.
- User facing error messages can now be specified within the Error
struct.
- Added helpers in types.go to simplify error construction.
- Updated ServeModuleVersions to explicitly return 404 when no versions
are found.
- Expanded test coverage in api_test.go to include 404 and 400 edge
cases.
Change-Id: I89c4be3941126c15df6aefdd21e4bbd2d3b23be1
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Ethan Lee <etha...@google.com>
kokoro-CI: kokoro <noreply...@google.com>
Reviewed-by: Jonathan Amsterdam <j...@google.com>
Files:
- M internal/api/api.go
- M internal/api/api_test.go
- M internal/api/params.go
- M internal/api/types.go
- M internal/frontend/server.go
Change size: M
Delta: 5 files changed, 130 insertions(+), 38 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
kokoro-CI-Passes: kokoro-CI+1 by kokoro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages