[oauth2] Fix DeviceAuth not populating RetrieveError
1 view
Skip to first unread message
Sean Liao (Gerrit)
Oct 21, 2025, 4:30:40 PM (2 days ago) Oct 21
to Andreas Goetz, Gerrit Bot, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, David Chase, Go LUCI, Jaana Dogan, Shin Fan, Cody Oss, Gopher Robot, golang-co...@googlegroups.com
Sean Liao submitted the change![]( "Open in Gerrit")
Change information
Commit message:
x/oauth2: populate RetrieveError from DeviceAuth
Endpoints may return errors when attempting to request device
authorization. Currently, these error codes are ignored and an
otherwise empty RetrieveError returned. This change populates
the RetrieveError similar to the oauth2 token exchange.
Fixes golang/go#75759
Change-Id: Ic00fecce290d3d3b4a40697b54ce74cc8cacab4d
GitHub-Last-Rev: 32c6ab5b8c0f8c2624cba0d536224a1fefcf0665
GitHub-Pull-Request: golang/oauth2#794
Reviewed-on: https://go-review.googlesource.com/c/oauth2/+/709215
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M deviceauth.go
- M deviceauth_test.go
- M oauth2_test.go
Change size: M
Delta: 3 files changed, 84 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Dmitri Shuralyov, +1 by David Chase, +2 by Sean Liao
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages