[go] text/template: fix slice builtin for pointers to arrays

1 view
Skip to first unread message

Sean Liao (Gerrit)

unread,
Dec 15, 2025, 12:05:07 PM (23 hours ago) Dec 15
to Nhan Nguyen, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, David Chase, Rob Pike, Go LUCI, golang-co...@googlegroups.com

Sean Liao submitted the change

Change information

Commit message:
text/template: fix slice builtin for pointers to arrays

The slice function now properly handles pointers to arrays by calling
indirect() to dereference pointers, matching the behavior of the index
function.

Fixes #39596
Change-Id: Id4920edbfd8fd3df3a181b59a61733f88b0f104d
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Rob Pike <r...@golang.org>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
  • M src/text/template/exec_test.go
  • M src/text/template/funcs.go
Change size: S
Delta: 2 files changed, 10 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Rob Pike, +1 by Michael Knyszek, +1 by Sean Liao, +1 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Id4920edbfd8fd3df3a181b59a61733f88b0f104d
Gerrit-Change-Number: 727400
Gerrit-PatchSet: 2
Gerrit-Owner: Nhan Nguyen <nhan...@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Rob Pike <r...@golang.org>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages