[go] text/template: fix slice builtin for pointers to arrays

1 view

Skip to first unread message

Sean Liao (Gerrit)

unread,

Dec 15, 2025, 12:05:07 PM (23 hours ago) Dec 15

to Nhan Nguyen, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, David Chase, Rob Pike, Go LUCI, golang-co...@googlegroups.com

Sean Liao submitted the change

Change information

Commit message:

text/template: fix slice builtin for pointers to arrays

The slice function now properly handles pointers to arrays by calling
indirect() to dereference pointers, matching the behavior of the index
function.

Fixes #39596

Change-Id: Id4920edbfd8fd3df3a181b59a61733f88b0f104d

Reviewed-on: https://go-review.googlesource.com/c/go/+/727400

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Sean Liao <se...@liao.dev>

Reviewed-by: Rob Pike <r...@golang.org>

Reviewed-by: David Chase <drc...@google.com>

Reviewed-by: Michael Knyszek <mkny...@google.com>

Files:

M src/text/template/exec_test.go
M src/text/template/funcs.go

Change size: S

Delta: 2 files changed, 10 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Rob Pike, +1 by Michael Knyszek, +1 by Sean Liao, +1 by David Chase
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages