[tools] refactor/satisfy: fix panic on invalid types

[Hongxiang Jiang (Gerrit)]

Hongxiang Jiang submitted the change

Change information

Commit message:

refactor/satisfy: fix panic on invalid types

If a composite literal had a type error the code used to panic
on a basic type near line 400 of find.go. The new code checks
for the invalid type, but also looks at its elements.

There are a modified marker test.

Fixes: golang/go#71538

Change-Id: Ia027e4481b79b733d311d0e05a4865b794fe9df7

Reviewed-on: https://go-review.googlesource.com/c/tools/+/812400

Reviewed-by: Hongxiang Jiang <hxj...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M gopls/internal/test/marker/testdata/rename/bad.txt
• M refactor/satisfy/find.go

Change size: M

Delta: 2 files changed, 59 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Hongxiang Jiang
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: Ia027e4481b79b733d311d0e05a4865b794fe9df7

Gerrit-Change-Number: 812400

Gerrit-PatchSet: 5

Gerrit-Owner: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>

Gerrit-Reviewer: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Gopher Robot <go...@golang.org>