[go] net/http/httputil: reject upgrade requests on non-HTTP/1.1 connections

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

1:51 PM (3 hours ago) 1:51 PM

to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Nicholas Husin, Nicholas Husin, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

net/http/httputil: reject upgrade requests on non-HTTP/1.1 connections

The Upgrade header is only valid on HTTP/1.1 connections.
(HTTP/2 has a different mechanism, see RFC 8441.)
Reject upgrade requests received on a non-HTTP/1.1 connection.

For #80416

Change-Id: I322ff6a3b4585c560f9ecaa206cd77446a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/801721

Reviewed-by: Nicholas Husin <n...@golang.org>

Reviewed-by: Nicholas Husin <hu...@google.com>

Auto-Submit: Damien Neil <dn...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

M src/net/http/httputil/reverseproxy.go

Change size: XS

Delta: 1 file changed, 6 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Nicholas Husin, +2 by Nicholas Husin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages