[go] cmd/compile: don't call memclrNoHeapPointersPreemptible from nosplit functions

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile: don't call memclrNoHeapPointersPreemptible from nosplit functions

That function will allow preemption, which could subsequently allow
for a stack copy (from shrinking). We can't let that happen inside
a nosplit function.

Update #78081

Change-Id: I12e77b50bbdcdd1e08e505a863b13cd9e1f814ee

Reviewed-on: https://go-review.googlesource.com/c/go/+/756123

Reviewed-by: Keith Randall <k...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Cherry Mui <cher...@google.com>

Auto-Submit: Keith Randall <k...@golang.org>

Files:

• M src/cmd/compile/internal/walk/assign.go
• M src/cmd/compile/internal/walk/range.go

Change size: XS

Delta: 2 files changed, 4 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Cherry Mui, +1 by Keith Randall
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I12e77b50bbdcdd1e08e505a863b13cd9e1f814ee

Gerrit-Change-Number: 756123

Gerrit-PatchSet: 3

Gerrit-Owner: Keith Randall <k...@golang.org>

Gerrit-Reviewer: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Keith Randall <k...@golang.org>

Gerrit-Reviewer: Keith Randall <k...@google.com>

Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>

Gerrit-Reviewer: Matthew Dempsky <mat...@go.dev>